fix(daemon): preserve disabled UI on manual start - #2205
vincentkoc wants to merge 1 commit into
Conversation
Signed-off-by: Vincent Koc <25068+vincentkoc@users.noreply.github.com>
|
Thanks for opening this — it has been seen, and it is queued. This note is automated, but it is not a brush-off: it exists so you know where your PR stands instead of having to guess from silence. Current review status: working through a backlog. What that means for this PR, concretely:
Things that will genuinely speed it up whenever review does happen:
If this fixes a bug, a reproduction we can run is worth more than a description of the symptom. Thanks for contributing, and sorry in advance for the wait. |
|
Thank you for the cold-start configuration fix. Current startup has separate loaded-configuration and explicit CLI override paths; review should prove that configured values survive a cold start while explicit flags retain precedence. Please keep the cold/warm and explicit-override cases as the acceptance boundary. This is queued for focused review. |
What does this PR do?
A cold
daemon startnow preserves a savedui_enabled=falsesetting. Previously it unconditionally requested UI configuration, rewrote the preference totrue, and started the HTTP listener.An explicit cold
--portor--openrequest keeps its existing UI-enabling behavior. Repeated bare starts report the disabled UI without incorrectly saying a browser request failed, and the configuration hint points toconfig set ui_enabled true. The configuration docs describe these semantics.Fixes #2114
Validation
scripts/test.sh BUILD_DIR=build/full-testspassed on macOS arm64: 8,022 tests passed, 10 platform skips, plus all prescribed process guards and security/ordering checks.git diff --check, formatting, cppcheck, and the NOLINT suppression check passed.scripts/lint.shexited 2 with 6,972 repo-wide clang-tidy diagnostics. An exact-path VFS comparison of unchanged and candidatesrc/main.cproduced 125 diagnostics each with the same diagnostic categories; none point to changed lines. The existingmain_run_daemon_ctlcognitive-complexity diagnostic increases from 82 to 89, already above the threshold of 25. Tools: Apple clang-format 21, clang-tidy 22.1.8, cppcheck 2.21.0.Checklist
git commit -s).